Set bottom padding of the main fragment when the mini player is visible#4134
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Aug 16, 2020
Merged
Set bottom padding of the main fragment when the mini player is visible#4134TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Conversation
opusforlife2
added
bug
Collaborator
|
Fixes the problem i had described in my issue on the subscription page 👍 |
TobiGr
approved these changes
Aug 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Makes more space underneath the mini player when it's visible or expanded into main player. So the last items in recyclerView from main fragment will be visible in both cases: opened or closed player. Works in multiWindow mode too.
Fixes the following issue(s)
closes #4047
Testing apk
app-release.zip
@XiangRongLin check this one, should be ok.
Agreement